Fix parsing of property values that contain comments with braces in them#104
Open
jmarianer wants to merge 1 commit intoreworkcss:masterfrom
Open
Fix parsing of property values that contain comments with braces in them#104jmarianer wants to merge 1 commit intoreworkcss:masterfrom
jmarianer wants to merge 1 commit intoreworkcss:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into this when parsing CSS from jquery-ui, which has /* {something} */ all over the place. I don't know a better way to include the comment regex, unfortunately.
My first pull request on GitHub. Be brutal, but be nice please.